fixes mem0 with valkey/redis issue#4055
fixes mem0 with valkey/redis issue#4055MatthiasHowellYopp wants to merge 2 commits intocrewAIInc:mainfrom
Conversation
|
Hey @MatthiasHowellYopp, maybe you can collapse all the commits into one for a cleaner git history Try this I am not a maintainer, feel free to ignore this... |
This would be great! |
1db23ea to
83e2f53
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
83e2f53 to
537b2f5
Compare
|
@greysonlalonde changes done, looks like I need you (or someone) to let the checks run. |
|
@greysonlalonde can you review - or recommend someone who can? tks. |
02dd3a4 to
3fcda10
Compare
|
@greysonlalonde Can we try again? looks lIke I need workflow approval and a review. |
e095719 to
8bc007d
Compare
|
@greysonlalonde Is there something I can do to get this to the other side of merged? Seems I'm back to needing the checks permitted. |
8bc007d to
fe7a87e
Compare
changes to support using mem0 with valkey/redis as external memory provider for crewai
fixes #4031
Note
Medium Risk
Changes query filter shape sent to local Mem0 backends for Valkey/Redis, which can affect search results/partitioning if misapplied. Risk is mitigated by extensive new tests covering provider and cloud/local combinations.
Overview
Fixes
Mem0Storagesearch filtering for local Mem0 backends using Valkey/Redis by flattening a singleANDcondition (e.g.,{ "AND": [{...}] }->{...}) since those vector stores don’t support Mem0’sAND/ORfilter structure.Adds regression coverage around Valkey/Redis vs other providers, ensures
MemoryClient(cloud) never flattens filters even iflocal_mem0_configis present, and hardens config parsing forNonelocal_mem0_config/vector_store. Test isolation is also improved by resetting the last event ID inconftest.py.Written by Cursor Bugbot for commit fe7a87e. This will update automatically on new commits. Configure here.