Skip to content

docker automated build#31

Open
pierrehpezier wants to merge 2 commits intocretz:masterfrom
pierrehpezier:master
Open

docker automated build#31
pierrehpezier wants to merge 2 commits intocretz:masterfrom
pierrehpezier:master

Conversation

@pierrehpezier
Copy link

build.sh will automatically build the release for linux x86 using docker && docker-compose.

@cretz
Copy link
Owner

cretz commented Aug 24, 2020

Neat, thanks. I had considered a Dockerfile at the root (I'd use multistage and/or put the shell script in the container instead of calling commands via compose, and I might use alpine instead of ubuntu). For now, since the steps are straightforward and cross-platform, I think I'll leave the Dockerfile out for now. But I'll leave this PR here for anyone that wants it.

@cretz
Copy link
Owner

cretz commented Aug 26, 2020

Nice update to use alpine and do the build inside the container there! Still not really wanting to merge, but this is helpful. Also note that, while the docker concerns itself with stripping and upx'ing the Tor binary at the end, this repo is more about the static libraries (i.e. the .a files produced). I will leave this PR open for anyone else that wants the docker file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants