Open
Conversation
Owner
|
Neat, thanks. I had considered a Dockerfile at the root (I'd use multistage and/or put the shell script in the container instead of calling commands via compose, and I might use alpine instead of ubuntu). For now, since the steps are straightforward and cross-platform, I think I'll leave the Dockerfile out for now. But I'll leave this PR here for anyone that wants it. |
Owner
|
Nice update to use alpine and do the build inside the container there! Still not really wanting to merge, but this is helpful. Also note that, while the docker concerns itself with stripping and upx'ing the Tor binary at the end, this repo is more about the static libraries (i.e. the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.sh will automatically build the release for linux x86 using docker && docker-compose.