Remove proto module as it seems to be unused and causes conflicts in other modules.#48
Open
neilgoodman wants to merge 1 commit intocreationix:masterfrom
neilgoodman:remove-proto
Open
Remove proto module as it seems to be unused and causes conflicts in other modules.#48neilgoodman wants to merge 1 commit intocreationix:masterfrom neilgoodman:remove-proto
neilgoodman wants to merge 1 commit intocreationix:masterfrom
neilgoodman:remove-proto
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proto module pollutes
Object.prototypeand causes issues with other modules. For example, I am using connect-assets and wheat together. connect-assets couldn't parse sprocket requires in a JavaScript file because the module dep-graph relies on a property calledmapon one of its objects, which conflicts with proto.It looks like the methods exposed in the proto module aren't even being used in wheat and I've been running a custom fork of the project without it for a few days with no issue.