attempt to remove execPipe function#44
Open
CrypticSwarm wants to merge 2 commits intocreationix:masterfrom
Open
attempt to remove execPipe function#44CrypticSwarm wants to merge 2 commits intocreationix:masterfrom
CrypticSwarm wants to merge 2 commits intocreationix:masterfrom
Conversation
|
Is it possible that the exec version is actually the correct behavior and execPipe is for some reason rendering them unnecessarily large? |
Contributor
Author
|
No, highly doubt it. This code doesn't work. I was mainly posting up for any suggestions why it wasn't working the way I thought it should. (The images don't render in the browser.) |
Had a problem with encoding. Exec contrary to the docs is handing back a string not a buffer.
Contributor
Author
|
This is now working correctly. It was a problem with the encoding of the streams. Should be ready to pull. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exec Pipe function looks to do about the same as what child_process.exec does.
I thought that it should be removed and use child_process.exec instead.
Currently this is not ready to merge. At the moment the graphs images don't render correctly. They are about 5% smaller. Any ideas why this isn't working?