If directory provided to readDir is empty still fire async callback#13
Open
neilgoodman wants to merge 1 commit intocreationix:masterfrom
neilgoodman:read-dir-callback-bug
Open
If directory provided to readDir is empty still fire async callback#13neilgoodman wants to merge 1 commit intocreationix:masterfrom neilgoodman:read-dir-callback-bug
neilgoodman wants to merge 1 commit intocreationix:masterfrom
neilgoodman:read-dir-callback-bug
Conversation
Author
|
Now looking at this it kind of doesn't make sense, because you can't have an empty directory in GIT. You can run into this issue during development, though, before you do any actual commits to the repo you are testing on. So this pull request probably only has limited usefulness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue when using
readDir()on an empty directory:callbackis never fired. This hangs my server.To reproduce:
This pull request contains a simple fix.