-
Notifications
You must be signed in to change notification settings - Fork 40
Add maintenance mode #2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add maintenance mode #2079
Conversation
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThe PR updates documentation across three files to reflect version 4.5.0 changes, adding new sections on Maintenance Mode, system-scope permissions ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/reference/modules/studio.rst (1)
5871-6062: Token Management & Maintenance Mode docs are solid; consider a couple of cross-linksThe new Token Management (API/Preview token) and Settings/Maintenance Mode sections read clearly and are consistent with the rest of the page.
Two small, optional improvements to tighten things up:
- In the API Token and Preview Token subsections, consider adding a short sentence that points to the Access Tokens configuration section (anchor
studio-access-tokens) so admins know where to tune issuer/audience/timeouts and related JWT settings.- In Maintenance Mode, consider adding a brief note that access during maintenance is governed by the corresponding system-scope permission (documented under Permission Descriptions on this page), so readers know how to allow specific users/groups to keep working while maintenance mode is on.
These would improve discoverability without changing the behavior you’ve documented.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
source/_static/images/content-author/maintenance-mode-on-fullscreen.webpsource/_static/images/content-author/maintenance-mode-on-login.webpsource/_static/images/content-author/maintenance-mode-on-while-working.webpsource/_static/images/system-admin/main-menu/main-menu-cluster.webpsource/_static/images/system-admin/main-menu/main-menu-settings.webpsource/_static/images/system-admin/main-menu/maintenance-mode-on-confirmation.webpsource/_static/images/system-admin/main-menu/maintenance-mode-on.webpsource/by-role/author/index.rstsource/includes/available-permissions-system-scope.rstsource/reference/modules/studio.rst
🔇 Additional comments (3)
source/includes/available-permissions-system-scope.rst (1)
110-121: Clarify enterpriseOnly scope for system_properties_manage permission.Line 115 applies the
|enterpriseOnly|tag only to the "Set system maintenance mode status" API endpoint. This is ambiguous—it's unclear whether the entiresystem_properties_managepermission is enterprise-only or only the maintenance mode API is restricted. For clarity, either:
- Move
|enterpriseOnly|to the permission name (lines 110) to indicate the permission itself is enterprise-only, or- Keep it on line 115 if only the maintenance mode API is enterprise-restricted, but add a note explaining this caveat.
source/by-role/author/index.rst (1)
597-639: The:ref:System Settings `` anchor exists and all three image files (maintenance-mode-on-while-working.webp, `maintenance-mode-on-login.webp`, `maintenance-mode-on-fullscreen.webp`) are correctly located in the repository. No technical issues found with the references or image paths.Likely an incorrect or invalid review comment.
source/reference/modules/studio.rst (1)
2-2: Version metadata aligns with new 4.5.0 contentUpdating
:last-updated:to4.5.0matches the newly addedSettings |enterpriseOnly|section marked as “Since 4.5.0”, so this header change looks correct.
Ticket reference or full description of what's in the PR
Add maintenance mode craftercms/craftercms#5652