Skip to content

ensure we can handle non-utf8 string arg values in the deprecator #18224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonkelly merged 2 commits into from
Jan 8, 2026
+2 −0
Merged

ensure we can handle non-utf8 string arg values in the deprecator #18224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be90709
ensure we can handle non-utf8 string arg values in the deprecator
i-just Jan 8, 2026
712fb9b
Release note
brandonkelly Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- The `utils/fix-field-layout-uids` command now checks for duplicate top-level field layout UUIDs. ([#18193](https://github.com/craftcms/cms/pull/18193))
- Fixed a bug where all plugin settings were being saved to the project config, rather than just posted settings. ([craftcms/commerce#4006](https://github.com/craftcms/commerce/issues/4006))
- Fixed a bug where custom selects could be positioned incorrectly after the window was resized. ([#18179](https://github.com/craftcms/cms/issues/18179))
- Fixed an error that could occur when logging a deprecation warning, if the backtrace contained any non-UTF-8-encoded strings. ([#18218](https://github.com/craftcms/cms/issues/18218))
- Fixed SSRF vulnerabilities. (GHSA-96pq-hxpw-rgh8, GHSA-m5r2-8p9x-hp5m, GHSA-8jr8-7hr4-vhfx)
- Fixed a SQL injection vulnerability. (GHSA-2453-mppf-46cj)
- Fixed an XSS vulnerability. (GHSA-9f5h-mmq6-2x78)
Expand Down
1 change: 1 addition & 0 deletions src/services/Deprecator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,7 @@ private function _argsToString(array $args): string
} else {
$strValue = '"' . $value . '"';
}
$strValue = mb_convert_encoding($strValue, 'UTF-8');
} elseif (is_array($value)) {
$strValue = '[' . $this->_argsToString($value) . ']';
} elseif ($value === null) {
Expand Down