-
Notifications
You must be signed in to change notification settings - Fork 25
RefreshIG: HttpClientUtils/AbstractBundler bug fixes #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
echicoine-icf
wants to merge
21
commits into
cqframework:master
Choose a base branch
from
echicoine-icf:refreshig_bugfix_transaction_bundle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RefreshIG: HttpClientUtils/AbstractBundler bug fixes #563
echicoine-icf
wants to merge
21
commits into
cqframework:master
from
echicoine-icf:refreshig_bugfix_transaction_bundle
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es can be posted in specific order together.
…ogger.info messages for readability.
…or each type of resource.
…cOS with the system managed cached Executor.
…into POST-and-PUT-handling
…e we need them someday, but appears not. At least have bug-free versions in the repository please.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #563 +/- ##
=========================================
Coverage 20.12% 20.13%
+ Complexity 1650 1649 -1
=========================================
Files 309 309
Lines 26976 26991 +15
Branches 4295 4306 +11
=========================================
+ Hits 5430 5435 +5
- Misses 20651 20660 +9
- Partials 895 896 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves some issues that existed in these classes. Should the need arise to ever re-enable MeasureBundler, and make use of HttpClientUtils, the refreshIG process works with these changes. At least would be a good idea to have bug-free versions of these classes in the repository.