Remove deprecated scales function number_si()#91
Open
olivroy wants to merge 1 commit intocpsievert:masterfrom
Open
Remove deprecated scales function number_si()#91olivroy wants to merge 1 commit intocpsievert:masterfrom
number_si()#91olivroy wants to merge 1 commit intocpsievert:masterfrom
Conversation
olivroy
changed the title
number_si(0
olivroy
changed the title
number_si(0number_si()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #84
label_number_si()is defunct now in favour oflabel_number(scale_cut = )https://www.tidyverse.org/blog/2022/04/scales-1-2-0/#numbers
This code would currently error due to a bug in scales r-lib/scales#413. But would work for scales 1.2.0 and 1.21, and will work for scales (>= 1.3.1)