You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 3, 2024. It is now read-only.
everything renders properly now including emojis, link previews, a cohost plus on and off checkbox, and the "Read More" cut (though it's just implemented as a details/summary rn so it doesn't look exactly the same as on cohost). i'm marking this as a draft because it doesn't give you feedback on what the sanitizer removed like prechoster does now. also licensing might be an issue, almost everything in src/markdown was copied out of cohost's source maps and edited until it built properly.
oh, neat!
hmmmmmmmmm yeah before merging this i’d definitely like to see some kinda confirmation that staff (*tags @jkap*) are ok with this level of reversing in a public repo12. i had kinda given up and was waiting for a potential Official Reference Renderer™ when the public API releases…
…i should probably also add some kinda code license before accepting a contribution this big lol added MIT which was already in package json apparently
for a quick review:
yeah the sanitizer warnings would be nice to keep
what changed in cohost-inherited.less? i had ignored it in prettier because it was 1:1 copy-pasted from cohost
that iframely api key probably can’t be there. i imagine it stops working outside localhost
(i dont really have plans to subscribe to iframely & i think it’d be fine to have a “iframely embed goes here” placeholder instead)
i18next doesn’t really seem needed here
i believe the footnote placement is actually correct. the cohost “read more” in the preview tab is a bit inaccurate (it’ll pick up html <hr> even though those don’t get converted to read more)
“You further agree not to copy, translate, port, modify or make derivative works of any portion of the Services” which the cohost-inherited.less file is probably technically already in violation of but, ↩
i agree the sanitizer warnings would be nice to keep i just don't know what the easiest way to add them back would be
i added the classes needed for the emojis and the iframely embeds, i tried to have the initial prettier run in a different commit than the one where i added the new styles but i don't think it worked
ok until it is Probably Legal to include the cohost renderer code in this repo, i have for now implemented a terrible, terrible hack in bb2533b. It simply loads the appropriate webpack chunks containing the renderer from cohost dot org itself. I don’t know how cohost does deployments or whether they keep the older static files around, so I’ve also kept the current renderer as fallback if it ever breaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
everything renders properly now including emojis, link previews, a cohost plus on and off checkbox, and the "Read More" cut (though it's just implemented as a details/summary rn so it doesn't look exactly the same as on cohost). i'm marking this as a draft because it doesn't give you feedback on what the sanitizer removed like prechoster does now. also licensing might be an issue, almost everything in
src/markdownwas copied out of cohost's source maps and edited until it built properly.