-
Notifications
You must be signed in to change notification settings - Fork 159
fix: hide couldnt load balances msg when balances are loading #6779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/2026-01-07
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughAdds a balances-loading flag to trade form validation: exposes Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
apps/cowswap-frontend/src/modules/tradeFormValidation/services/validateTradeForm.ts
Outdated
Show resolved
Hide resolved
elena-zh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kernelwhisperer , thank you!
However, I still can see this message ('could not load balances') when I connect to a wallet (to Safe with WC, or to MM).

To reproduce:
- open the PR preview link
- connect to Safe wallet using WC
Then, sometimes. when I switch between networks using network selector (connected to MM), I can see 'fetching balances' message flashing on a quote load, but then I get 'could not load balances' error again.
See the video: the issue happened when I switched to Base: https://www.loom.com/share/e896d51a2d314e0aaba185ada0ebb465
98f40f0 to
397c499
Compare
Summary
Fixes #4127
The issue was that the form validation was not taking into account the
isBalancesLoadingstate.To Test
As per the issue:
Connect to a wallet (using WC or open the app inside Safe --> most likely you will immediately reproduce the issue)
AR: each time when app is loading after changing a network/connection, 'Couldn't load balances' message appears and is displayed up to 20 seconds
Summary by CodeRabbit
New Features
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.