Skip to content

Conversation

@noslav
Copy link
Member

@noslav noslav commented Nov 4, 2025

Fix golangci-lint deprecation warnings and typecheck error

This PR addresses linting configuration issues and fixes a compilation error in the test suite.

Changes

1. Update .golangci.yml configuration

  • Fixed: Deprecated configuration options that caused warnings
  • Migrated run.skip-filesissues.exclude-files
  • Migrated run.skip-dirsissues.exclude-dirs
  • These options were deprecated in recent golangci-lint versions and needed to be moved under the issues section

2. Fix undefined function in test

  • Fixed: internal/types/types_test/int_test.go:50
  • Changed common.StringToAddress()common.HexToAddress()
  • StringToAddress is not a valid function in the go-ethereum/common package
  • HexToAddress is the correct function for converting hex string addresses

Errors Fixed

Error: internal/types/types_test/int_test.go:50:17: undefined: common.StringToAddress (typecheck)

Testing

  • ✅ golangci-lint v1.64.7 runs without deprecation warnings
  • ✅ Typecheck passes successfully
  • ✅ All linters configured correctly

Signed-off-by: Pranay Valson <pranay.valson@gmail.com>
Signed-off-by: Pranay Valson <pranay.valson@gmail.com>
Signed-off-by: Pranay Valson <pranay.valson@gmail.com>
Signed-off-by: Pranay Valson <pranay.valson@gmail.com>
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.31%. Comparing base (83557af) to head (27a6f3b).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   15.31%   15.31%           
=======================================
  Files          52       52           
  Lines        6112     6112           
=======================================
  Hits          936      936           
  Misses       5131     5131           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Pranay Valson <pranay.valson@gmail.com>
@noslav noslav merged commit c188c1e into main Nov 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant