Skip to content

Conversation

@mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 29, 2025

Description

On ICS consumer chain, stakingKeeper.GetValidatorByConsAddr() fails on staking keeper since no validator record. The validator set is replicated via cross-chain validation module instead of local staking keeper. Validators of consumer are provided by the provider chain through Validator Set Change packets via IBC, no actual validator management in consumer's staking module.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.49%. Comparing base (84c2a0a) to head (203152c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
- Coverage   65.49%   65.49%   -0.01%     
==========================================
  Files         318      318              
  Lines       22222    22217       -5     
==========================================
- Hits        14555    14550       -5     
  Misses       6502     6502              
  Partials     1165     1165              
Files with missing lines Coverage Δ
x/vm/keeper/block_proposer.go 73.91% <100.00%> (-4.66%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmsqe mmsqe marked this pull request as ready for review December 29, 2025 14:50
@mmsqe mmsqe changed the title feat: allow GetCoinbaseAddress support in ICS consumer chain fix: GetCoinbaseAddress Bech32 address conversion for block.coinbase Jan 5, 2026
@mmsqe mmsqe changed the title fix: GetCoinbaseAddress Bech32 address conversion for block.coinbase fix: allow ICS consumer to sign eth tx when proposer address comes from provider Jan 6, 2026
@vladjdk
Copy link
Member

vladjdk commented Jan 6, 2026

@mmsqe could you assign this to an issue with a description of why this is needed? We're in the process of deprecating ICS, so this may not be an issue in the future.

@mmsqe
Copy link
Collaborator Author

mmsqe commented Jan 7, 2026

@mmsqe could you assign this to an issue with a description of why this is needed? We're in the process of deprecating ICS, so this may not be an issue in the future.

yes, but do you mean https://github.com/cosmos/interchain-security will be deprecated soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants