-
Notifications
You must be signed in to change notification settings - Fork 146
fix: allow ICS consumer to sign eth tx when proposer address comes from provider #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
==========================================
- Coverage 65.49% 65.49% -0.01%
==========================================
Files 318 318
Lines 22222 22217 -5
==========================================
- Hits 14555 14550 -5
Misses 6502 6502
Partials 1165 1165
🚀 New features to boost your workflow:
|
|
@mmsqe could you assign this to an issue with a description of why this is needed? We're in the process of deprecating ICS, so this may not be an issue in the future. |
yes, but do you mean https://github.com/cosmos/interchain-security will be deprecated soon? |
Description
On ICS consumer chain,
stakingKeeper.GetValidatorByConsAddr()fails on staking keeper since no validator record. The validator set is replicated via cross-chain validation module instead of local staking keeper. Validators of consumer are provided by the provider chain through Validator Set Change packets via IBC, no actual validator management in consumer's staking module.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch