refactor: Using the MsgEthereumTx interface in the rpc module #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@nowooj a few conflicts here |
vladjdk
reviewed
Jan 7, 2026
| } | ||
| if ctx.IsCheckTx() && !simulate && d.pendingTxListener != nil { | ||
| for _, msg := range tx.GetMsgs() { | ||
| if ethTx, ok := msg.(*evmtypes.MsgEthereumTx); ok { |
Member
There was a problem hiding this comment.
Why are we leaving some *evmtypes.MsgEthereumTx as pointers instead of the interface?
Author
There was a problem hiding this comment.
I thought that newly execute tx, for example tx coming through ante handler or mempool, would always use the latest evmtypes.MsgEthereumTx
nowooj
force-pushed
the
refactor/interface-rpcEthTx
branch
from
a1d6fed to
3da79d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code doesn't cover all MsgEthereumTx implementations within the rpc module, but it does cover the query part. This code can be expanded and structured into a completely independent code structure.
Removing Hash() hasn't important to do with the PR, but it was added for backward compatibility since ethermint uses Hash as a variable.
Closes: #853
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch