Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the installation flow
Before: The flow was:
This meant if bundle wasn't available, the code would try to run it anyway, fail, and cache that failure - blocking all
future attempts.
After: The new flow is:
This means if you don't have bundle in your PATH (like on this machine), it skips the bundle steps entirely and just
tries gem install instead of failing and caching the failure.
Fixed cache key bug
Before: cache keys were generated with relative paths 🤦
After: cache keys are generated with absolute paths
Added cache TTL
Before: install failure cache lived forever until manually cleared
After: 7 day default TTL for failure cache
Added test suite setup