test: python 3.13 Compatibility Test #649
Conversation
lu11y0
requested review from
Anshgrover23,
Suyashd999 and
mikejmorgan-ai
as code owners
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds Python 3.13 support: updates CI workflows to test on 3.13, updates project metadata and Black target versions, and adds a benchmark script comparing runtime behavior between Python versions. Changes
Sequence Diagram(s)(omitted — changes do not introduce multi-component control-flow requiring a sequence diagram) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CLA Verification FailedThe following contributors have not signed the Contributor License Agreement:
How to Sign
Verified SignersThis check runs automatically. Maintainers can update |
Summary of ChangesHello @lu11y0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request officially introduces support for Python 3.13, ensuring the project's forward compatibility with the latest Python version. It integrates Python 3.13 into the continuous integration pipeline and showcases notable performance enhancements observed with this new release. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
lu11y0
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully adds support for Python 3.13 by updating project configuration files. It's great to see a benchmark script included to validate performance improvements. The changes look good. I've added a couple of suggestions to the benchmark script to improve its accuracy by separating setup code from the code being measured.
| dict_ops = """ | ||
| d = {i: i*2 for i in range(100)} | ||
| result = [v for k,v in d.items() if v > 50] | ||
| """ | ||
| time_dicts = timeit.timeit(dict_ops, number=1000) |
There was a problem hiding this comment.
Similar to the YAML benchmark, the dictionary creation is happening inside the timed loop. If the intention is to benchmark the list comprehension that filters the dictionary, it would be more accurate to create the dictionary d in the setup argument of timeit.timeit. This isolates the operation you want to measure.
dict_setup = "d = {i: i*2 for i in range(100)}"
dict_stmt = "result = [v for k,v in d.items() if v > 50]"
time_dicts = timeit.timeit(stmt=dict_stmt, setup=dict_setup, number=1000)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
2 participants
Related Issue
Closes #272
Summary
Performance benchmarks 3.11 vs 3.13
AVERAGE: 3.11=0.1427s | 3.13=0.1156s → 3.13 = 19% FASTER!
Run :
python3.11 benchmark_313.pyandpython3.13 benchmark_313.pyRecordings
benchmark_313.py execution :
Screen.Recording.2025-12-23.170834.mp4
647 tests passing and benchmark test:
Screen.Recording.2025-12-22.220446.1.mp4
other tests :
Screen.Recording.2025-12-22.223159.mp4
AI Disclosure
Used Gpt 4.1 model to generate test files
Checklist
pytest tests/)[#XX] DescriptionSummary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.