Skip to content

Fix/mappedcolumn key attr#151

Merged
AbdealiLoKo merged 2 commits intomainfrom
fix/mappedcolumn-key-attr
Dec 16, 2025
Merged

Fix/mappedcolumn key attr#151
AbdealiLoKo merged 2 commits intomainfrom
fix/mappedcolumn-key-attr

Conversation

@ashish16052
Copy link
Collaborator

No description provided.

@ashish16052 ashish16052 force-pushed the fix/mappedcolumn-key-attr branch 7 times, most recently from 43ef22f to b67fb8d Compare June 5, 2025 06:43
@coveralls
Copy link

coveralls commented Jun 5, 2025

Pull Request Test Coverage Report for Build 15460943355

Details

  • 90 of 91 (98.9%) changed or added relevant lines in 44 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.739%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sqlalchemy_history/model_builder.py 9 10 90.0%
Totals Coverage Status
Change from base Build 11122595953: -0.02%
Covered Lines: 4925
Relevant Lines: 5182

💛 - Coveralls

@ashish16052 ashish16052 force-pushed the fix/mappedcolumn-key-attr branch from b67fb8d to ab259a7 Compare June 5, 2025 07:19
@AbdealiLoKo AbdealiLoKo force-pushed the fix/mappedcolumn-key-attr branch from ab259a7 to aaad074 Compare November 18, 2025 22:57
@AbdealiLoKo
Copy link
Contributor

I've spent some time trying to update the repo CI systems as things were failing.
I see there is interest in getting this PR merged, and would love to merge it -- but I see there are no testcases here

If someone could add testcases, that would be great !

tested copy_mapper_args for three cases:
1. when col is MappedColumn
2. when col is Column object
3. when col is String
@ashish16052
Copy link
Collaborator Author

I've spent some time trying to update the repo CI systems as things were failing. I see there is interest in getting this PR merged, and would love to merge it -- but I see there are no testcases here

If someone could add testcases, that would be great !

Added minimal unit tests

@AbdealiLoKo AbdealiLoKo merged commit b9bd8cf into main Dec 16, 2025
12 checks passed
@AbdealiLoKo AbdealiLoKo deleted the fix/mappedcolumn-key-attr branch December 16, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants