Fix builder not copying hybrid_property.expr and other props to the version class#147
Merged
AbdealiLoKo merged 1 commit intocorridor:mainfrom Nov 18, 2025
Merged
Conversation
benedikt-bartscher
approved these changes
Mar 28, 2025
|
Thanks for fixing it, we ran into problems here as well! @aditya051293 Would you mind having a look? |
ashish16052
approved these changes
Apr 15, 2025
Collaborator
ashish16052
left a comment
There was a problem hiding this comment.
@maximvlah Looks good to me. Can you please create a tracking issue and reference it in your commits for better traceability?
d039a6b to
b9c5e86
Compare
When creating the hybrid-prop in the version class, we just copied the getter. Create the hybrid-prop properly
b9c5e86 to
7546991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found and fixed the bug in
Builder.create_hybrid_properties. It was only copying the python hybrid property function to the corresponding version class but not the SQL equivalent, thus we would get the error below: