[BUG] allow setting composer variable to nil #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sandell <mdsandell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The composer API's setVariable method did not allow you to set a variable to nil, as I just found out while debugging my app. While I can probably work around it by setting to false instead, I have to be careful that other code in my app doesn't behave differently when given a boolean here, since I truly want to clear the variable completely in my use case. If this is considered a "feature" and you don't want to move forward with this fix, maybe we can get the docs updated with a new "gotcha?"
Signed-off-by: Mark Sandell mdsandell@gmail.com