This repository was archived by the owner on Sep 22, 2020. It is now read-only.
blockset.go: add BlockReconstructor interface for erasure-encoding #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also for replication, shall we have a separate replication blockset implementation? Or shall we extend the existing one? They can share part of the code though. But I prefer a separate implementation to start with. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #165 part 1.
I use
Reconstructinstead ofRebuildsince people usuallyReconstructin reed-solomon world.@barakmich I am not sure if we should add this into the existing BlockSet interface. Most of the blockset implementation (as least for today) should not implement Reconstruct.