login1: add methods to get session/user properties #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
Aug 31, 2022
Contributor
|
Thanks for the patch! I left some comments in review. Feel free to squash the commits when you think you are done, and I'll have a further look. |
Contributor
|
Indeed, this logic doesn't have much unit-testing coverage, as that really doesn't add much. |
ilyam8
force-pushed
the
feat_login1_methods_to_get_properties
branch
from
5020cdb to
d3e99ab
Compare
Contributor
Author
|
@lucab, thanks for the quick review 🙋♂️ I believe I've addressed all your comments. |
ilyam8
changed the title
lucab
approved these changes
Sep 16, 2022
Contributor
lucab
left a comment
lucab
left a comment
There was a problem hiding this comment.
LGTM, thanks for the patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds context-aware methods to get a property/all properties for a user or session.
I am not sure how to unit-test them, the majority of login1 connection methods have no unit tests. I think it will be possible after #396 (will be possible to mock both dbus.Conn and dbus.BusObject).