Make holder column of (non)-fungible-token tables nullable#220
Open
vanderheijden86 wants to merge 1 commit intocorda:masterfrom
Open
Make holder column of (non)-fungible-token tables nullable#220vanderheijden86 wants to merge 1 commit intocorda:masterfrom
vanderheijden86 wants to merge 1 commit intocorda:masterfrom
Conversation
Contributor
|
thanks @vanderheijden86 - we have actually merged a very similar PR into: #221 which has added tests for database compatibility This has now been "published" as 1.2.3-ALPHA, and we are working towards releasing the official 1.2.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Confidential Identities in a setup where TXs are sent to an observer node, the observer node cannot resolve the AnonymousParty (resulting from Confidential Identities) into an actual Party. As such when storing Tokens that result from above TXs we see this error message:
This MR will resolve those issues as it will allow us to update the database queryable state table even when the value for holder is NULL.