-
Notifications
You must be signed in to change notification settings - Fork 0
884: Ruby Upgrade #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e86c19a
884: Ruby Upgrade
ehimen-io 2f2ad06
884: Upgrade ruby in CI
ehimen-io 6373230
884: Upgrade ruby setup version
ehimen-io 6d1b239
884: Address PR comments
ehimen-io c9bfc33
884: Upgrade bundler
ehimen-io 56c9ab6
884: Bound bundler versions
ehimen-io File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.7.4 | ||
| 4.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Changelog | ||
|
|
||
| ## [1.0.0] - 2026-02-11 | ||
lavaturtle marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ### Breaking Changes | ||
| - Now requires Faraday 2.x (previously supported Faraday 1.x) | ||
| - Dropped support for Ruby versions older than 3.3. Officially supported versions are Ruby 3.3, 3.4, and 4.0. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,6 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| source 'http://rubygems.org' | ||
| source 'https://rubygems.org' | ||
|
|
||
| gem 'vertebrae', '>= 0.6.0' | ||
|
|
||
| # Add dependencies to develop your gem here. | ||
| # Include everything needed to run rake, tests, features, etc. | ||
| group :development do | ||
| gem 'bundler' | ||
| gem 'juwelier', git: 'https://github.com/flajann2/juwelier.git' | ||
| gem 'pry' | ||
| gem 'pry-byebug' | ||
| gem 'rspec' | ||
| gem 'rubocop' | ||
| gem 'webmock' | ||
| end | ||
| # Specify your gem's dependencies in tijuana_client.gemspec | ||
| gemspec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,8 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require 'rubygems' | ||
| require 'bundler' | ||
| begin | ||
| Bundler.setup(:default, :development) | ||
| rescue Bundler::BundlerError => e | ||
| warn e.message | ||
| warn 'Run `bundle install` to install missing gems' | ||
| exit e.status_code | ||
| end | ||
| require 'rake' | ||
|
|
||
| require 'juwelier' | ||
| Juwelier::Tasks.new do |gem| | ||
| # gem is a Gem::Specification... see http://docs.rubygems.org/read/chapter/20 for more options | ||
| gem.name = 'tijuana_client' | ||
| gem.homepage = 'http://github.com/controlshift/tijuana_client' | ||
| gem.license = 'MIT' | ||
| gem.summary = %(API client for Tijuana) | ||
| gem.description = %(An API client for the code that runs Getup.org.au) | ||
| gem.email = 'nathan@controlshiftlabs.com' | ||
| gem.authors = ['Nathan Woodhull'] | ||
| # dependencies defined in Gemfile | ||
| end | ||
| Juwelier::RubygemsDotOrgTasks.new | ||
|
|
||
| require 'rspec/core' | ||
| require 'bundler/gem_tasks' | ||
| require 'rspec/core/rake_task' | ||
| RSpec::Core::RakeTask.new(:spec) do |spec| | ||
| spec.pattern = FileList['spec/**/*_spec.rb'] | ||
| end | ||
|
|
||
| RSpec::Core::RakeTask.new(:rcov) do |spec| | ||
| spec.pattern = 'spec/**/*_spec.rb' | ||
| spec.rcov = true | ||
| end | ||
| RSpec::Core::RakeTask.new(:spec) | ||
|
|
||
| task default: :spec | ||
|
|
||
| require 'rdoc/task' | ||
| Rake::RDocTask.new do |rdoc| | ||
| version = File.exist?('VERSION') ? File.read('VERSION') : '' | ||
|
|
||
| rdoc.rdoc_dir = 'rdoc' | ||
| rdoc.title = "porpoise_external_actions #{version}" | ||
| rdoc.rdoc_files.include('README*') | ||
| rdoc.rdoc_files.include('lib/**/*.rb') | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 0.3.1 | ||
| 1.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,71 +1,38 @@ | ||
| # Generated by juwelier | ||
| # DO NOT EDIT THIS FILE DIRECTLY | ||
| # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec' | ||
| # -*- encoding: utf-8 -*- | ||
| # stub: tijuana_client 0.3.1 ruby lib | ||
| # frozen_string_literal: true | ||
|
|
||
| Gem::Specification.new do |s| | ||
| s.name = "tijuana_client".freeze | ||
| s.version = "0.3.1" | ||
| lib = File.expand_path('lib', __dir__) | ||
| $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) | ||
|
|
||
| s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version= | ||
| s.require_paths = ["lib".freeze] | ||
| s.authors = ["Nathan Woodhull".freeze] | ||
| s.date = "2021-07-23" | ||
| s.description = "An API client for the code that runs Getup.org.au".freeze | ||
| s.email = "nathan@controlshiftlabs.com".freeze | ||
| s.extra_rdoc_files = [ | ||
| "LICENSE.txt", | ||
| "README.md" | ||
| ] | ||
| s.files = [ | ||
| ".github/workflows/ci.yml", | ||
| ".rubocop.yml", | ||
| ".ruby-gemset", | ||
| ".ruby-version", | ||
| "Gemfile", | ||
| "LICENSE.txt", | ||
| "README.md", | ||
| "Rakefile", | ||
| "VERSION", | ||
| "lib/tijuana_client.rb", | ||
| "lib/tijuana_client/base.rb", | ||
| "lib/tijuana_client/client.rb", | ||
| "lib/tijuana_client/error_middleware.rb", | ||
| "lib/tijuana_client/user.rb", | ||
| "spec/client_spec.rb", | ||
| "spec/spec_helper.rb", | ||
| "spec/tijuana_spec.rb", | ||
| "spec/user_spec.rb", | ||
| "tijuana_client.gemspec" | ||
| ] | ||
| s.homepage = "http://github.com/controlshift/tijuana_client".freeze | ||
| s.licenses = ["MIT".freeze] | ||
| s.rubygems_version = "3.1.6".freeze | ||
| s.summary = "API client for Tijuana".freeze | ||
| Gem::Specification.new do |spec| | ||
| spec.name = 'tijuana_client' | ||
| spec.version = File.read(File.expand_path('VERSION', __dir__)).strip | ||
| spec.authors = ['Nathan Woodhull', 'Owens Ehimen', 'Diego Marcet', 'Grey Moore'] | ||
| spec.email = ['talk@controlshiftlabs.com'] | ||
|
|
||
| if s.respond_to? :specification_version then | ||
| s.specification_version = 4 | ||
| end | ||
| spec.summary = 'API client for Tijuana' | ||
| spec.description = 'An API client for the code that runs Getup.org.au' | ||
| spec.homepage = 'https://github.com/controlshift/tijuana_client' | ||
| spec.license = 'MIT' | ||
|
|
||
| if s.respond_to? :add_runtime_dependency then | ||
| s.add_runtime_dependency(%q<vertebrae>.freeze, [">= 0.6.0"]) | ||
| s.add_development_dependency(%q<bundler>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<juwelier>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<pry>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<pry-byebug>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<rspec>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<rubocop>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<webmock>.freeze, [">= 0"]) | ||
| else | ||
| s.add_dependency(%q<vertebrae>.freeze, [">= 0.6.0"]) | ||
| s.add_dependency(%q<bundler>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<juwelier>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<pry>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<pry-byebug>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<rspec>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<rubocop>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<webmock>.freeze, [">= 0"]) | ||
| spec.files = Dir.chdir(File.expand_path(__dir__)) do | ||
| `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } | ||
| end | ||
| end | ||
| spec.require_paths = ['lib'] | ||
|
|
||
| spec.required_ruby_version = ['>= 3.3', '< 5.0'] | ||
|
|
||
| # Runtime dependencies | ||
| spec.add_runtime_dependency 'vertebrae', '~> 1.0' | ||
| spec.add_runtime_dependency 'faraday', '~> 2.0' | ||
|
|
||
| # Development dependencies | ||
| spec.add_development_dependency 'bundler', '>= 2.0', '< 5.0' | ||
| spec.add_development_dependency 'pry', '~> 0.14' | ||
| spec.add_development_dependency 'pry-byebug', '~> 3.0' | ||
| spec.add_development_dependency 'rake', '~> 13.0' | ||
| spec.add_development_dependency 'rspec', '~> 3.0' | ||
| spec.add_development_dependency 'rubocop', '~> 1.0' | ||
| spec.add_development_dependency 'webmock', '~> 3.0' | ||
|
|
||
| spec.metadata['rubygems_mfa_required'] = 'true' | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the bundle install happen automatically now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah its part of the setup-ruby script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/controlshift/tijuana_client/actions/runs/22203305683/job/64221372151?pr=3#step:3:20