Remove logging to Cloudwatch from EC2 instances#10
Merged
anero merged 2 commits intocontrolshift-devfrom Feb 26, 2025
Merged
Conversation
lavaturtle
approved these changes
Feb 26, 2025
lavaturtle
left a comment
lavaturtle
left a comment
There was a problem hiding this comment.
👍 Looks reasonable. I guess we'll know if it works once we rebuild the stack and roll it out on Buildkite?
| # sometimes that fails, are various CloudFormation Stacks and S3 Buckets left around. | ||
| # | ||
| # This is a safety net at the end of the build that attempts to delete any resources created by this | ||
| # pipeline more than a day ago, regardless of if they were created in the current build or not. |
There was a problem hiding this comment.
Are we making any changes to this cleanup process, or just updating the comment?
Author
There was a problem hiding this comment.
I think they're referring to logs created during the AMI build, which I'm hoping won't be created, but I may be wrong. I was mostly trying to keep comments current with the changes we're making. My plan is to delete all log groups from CloudWatch before deploying these changes and check if any of them are recreated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed integration to send logs to Cloudwatch from EC2 instances to reduce the cost of running Buildkite instances.
Disabling this integration is not currently supported by Buildkite, so we need to change the AMIs and the Cloudformation template to avoid it.
Part of CON-301