-
Notifications
You must be signed in to change notification settings - Fork 0
CON 889: Upgrade ruby to 4.0.1 + downstream updates #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1ded4ad
CON 889: Upgrade ruby to 4.0.1 + downstream updates
ehimen-io e4476e2
CON 889: fix rubocop
ehimen-io 6928f63
CON 889: PR comments
ehimen-io 3ddfc01
CON 889: Remove mashify require statement
ehimen-io a05e6cf
CON 889: Add hashie patch number, update CHANGELOG.md
ehimen-io d5780e2
CON 889: Update vertebrae version
ehimen-io File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.2.2 | ||
| 4.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehimen-io marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,6 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| source 'http://rubygems.org' | ||
| source 'https://rubygems.org' | ||
|
|
||
| gem 'vertebrae', '>= 0.6.0' | ||
|
|
||
| group :development do | ||
| gem 'bundler', '>= 2.0', '<3.0' | ||
| gem 'byebug' | ||
| gem 'em-http-request', '>=1.1.5', '<2.0' | ||
| gem 'em-synchrony', '>=1.0.6', '<2.0' | ||
| gem 'eventmachine', '>=1.2.5', '<2.0' | ||
| gem 'juwelier', git: 'https://github.com/flajann2/juwelier.git' | ||
| gem 'rspec', '~> 3.7' | ||
| gem 'rubocop' | ||
| gem 'webmock', '~> 3.3' | ||
| end | ||
| # Specify your gem's dependencies in action_kit_rest.gemspec | ||
| gemspec | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This adds all the dependencies from the gemspec
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Neat! |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,13 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require 'rubygems' | ||
| require 'bundler' | ||
| begin | ||
| Bundler.setup(:default, :development) | ||
| rescue Bundler::BundlerError => e | ||
| warn e.message | ||
| warn 'Run `bundle install` to install missing gems' | ||
| exit e.status_code | ||
| end | ||
| require 'rake' | ||
| require './lib/action_kit_rest/version' | ||
|
|
||
| require 'juwelier' | ||
| Juwelier::Tasks.new do |gem| | ||
| gem.name = 'action_kit_rest' | ||
| gem.version = ActionKitRest::VERSION::STRING | ||
| gem.homepage = 'http://github.com/controlshift/action_kit_rest' | ||
| gem.license = 'MIT' | ||
| gem.summary = %(A wrapper for the ActionKit REST API) | ||
| gem.description = %(Gem for interacting with the ActionKit API) | ||
| gem.email = 'systems@controlshiftlabs.com' | ||
| gem.authors = ['Nathan Woodhull', 'Diego Marcet', 'Grey Moore'] | ||
| # dependencies defined in Gemfile | ||
| end | ||
| Juwelier::RubygemsDotOrgTasks.new | ||
|
|
||
| require 'bundler/gem_tasks' | ||
| require 'rspec/core/rake_task' | ||
|
|
||
| desc 'Default: run specs.' | ||
| task default: :spec | ||
|
|
||
| desc 'Run specs' | ||
| RSpec::Core::RakeTask.new do |t| | ||
| t.pattern = './spec/**/*_spec.rb' # don't need this, it's default. | ||
| RSpec::Core::RakeTask.new(:spec) do |t| | ||
| t.pattern = './spec/**/*_spec.rb' | ||
| t.rspec_opts = '--color' | ||
| end | ||
|
|
||
| require 'rdoc/task' | ||
| Rake::RDocTask.new do |rdoc| | ||
| version = File.exist?('VERSION') ? File.read('VERSION') : '' | ||
|
|
||
| rdoc.rdoc_dir = 'rdoc' | ||
| rdoc.title = "action_kit_rest #{version}" | ||
| rdoc.rdoc_files.include('README*') | ||
| rdoc.rdoc_files.include('lib/**/*.rb') | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,111 +1,49 @@ | ||
| # Generated by juwelier | ||
| # DO NOT EDIT THIS FILE DIRECTLY | ||
| # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec' | ||
| # -*- encoding: utf-8 -*- | ||
| # stub: action_kit_rest 0.4.11 ruby lib | ||
| # frozen_string_literal: true | ||
|
|
||
| Gem::Specification.new do |s| | ||
| s.name = "action_kit_rest".freeze | ||
| s.version = "0.4.11" | ||
| require_relative "lib/action_kit_rest/version" | ||
|
|
||
| s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version= | ||
| s.require_paths = ["lib".freeze] | ||
| s.authors = ["Nathan Woodhull".freeze, "Diego Marcet".freeze, "Grey Moore".freeze] | ||
| s.date = "2025-10-27" | ||
| s.description = "Gem for interacting with the ActionKit API".freeze | ||
| s.email = "systems@controlshiftlabs.com".freeze | ||
| s.extra_rdoc_files = [ | ||
| "LICENSE.txt", | ||
| "README.md" | ||
| ] | ||
| s.files = [ | ||
| ".document", | ||
| ".github/workflows/ci.yml", | ||
| ".rspec", | ||
| ".rubocop.yml", | ||
| ".ruby-gemset", | ||
| ".ruby-version", | ||
| "CHANGELOG.md", | ||
| "Gemfile", | ||
| "LICENSE.txt", | ||
| "README.md", | ||
| "Rakefile", | ||
| "action_kit_rest.gemspec", | ||
| "lib/action_kit_rest.rb", | ||
| "lib/action_kit_rest/action.rb", | ||
| "lib/action_kit_rest/actions/event_create_action.rb", | ||
| "lib/action_kit_rest/actions/event_signup_action.rb", | ||
| "lib/action_kit_rest/actions/unsubscribe_action.rb", | ||
| "lib/action_kit_rest/allowed_user_field.rb", | ||
| "lib/action_kit_rest/api.rb", | ||
| "lib/action_kit_rest/base.rb", | ||
| "lib/action_kit_rest/client.rb", | ||
| "lib/action_kit_rest/event.rb", | ||
| "lib/action_kit_rest/event_signup.rb", | ||
| "lib/action_kit_rest/language.rb", | ||
| "lib/action_kit_rest/list.rb", | ||
| "lib/action_kit_rest/page.rb", | ||
| "lib/action_kit_rest/pages/base.rb", | ||
| "lib/action_kit_rest/pages/donation_page.rb", | ||
| "lib/action_kit_rest/pages/event_campaign_page.rb", | ||
| "lib/action_kit_rest/pages/import_page.rb", | ||
| "lib/action_kit_rest/pages/signup_page.rb", | ||
| "lib/action_kit_rest/pages/unsubscribe_page.rb", | ||
| "lib/action_kit_rest/phone.rb", | ||
| "lib/action_kit_rest/railties.rb", | ||
| "lib/action_kit_rest/response/collection.rb", | ||
| "lib/action_kit_rest/response/raise_error.rb", | ||
| "lib/action_kit_rest/response/validation_error.rb", | ||
| "lib/action_kit_rest/response/wrapper.rb", | ||
| "lib/action_kit_rest/tag.rb", | ||
| "lib/action_kit_rest/user.rb", | ||
| "lib/action_kit_rest/version.rb", | ||
| "spec/fixtures/action/event_create_action.json", | ||
| "spec/fixtures/action/event_signup_action.json", | ||
| "spec/fixtures/allowed_user_field/get.json", | ||
| "spec/fixtures/allowed_user_field/list.json", | ||
| "spec/fixtures/allowed_user_field/list_filtered.json", | ||
| "spec/fixtures/error.json", | ||
| "spec/fixtures/page/campaign.json", | ||
| "spec/fixtures/page/collection.json", | ||
| "spec/fixtures/page/find_campaign.json", | ||
| "spec/fixtures/page/find_event_create.json", | ||
| "spec/fixtures/page/find_event_signup.json", | ||
| "spec/fixtures/page/object.json", | ||
| "spec/fixtures/phone/object.json", | ||
| "spec/fixtures/user/object_with_phones.json", | ||
| "spec/fixtures/user/object_without_phones.json", | ||
| "spec/lib/action_kit_rest/actions/event_create_action_spec.rb", | ||
| "spec/lib/action_kit_rest/actions/event_signup_action_spec.rb", | ||
| "spec/lib/action_kit_rest/allowed_user_field_spec.rb", | ||
| "spec/lib/action_kit_rest/api_spec.rb", | ||
| "spec/lib/action_kit_rest/logger_spec.rb", | ||
| "spec/lib/action_kit_rest/page_spec.rb", | ||
| "spec/lib/action_kit_rest/pages/event_campaign_page_spec.rb", | ||
| "spec/lib/action_kit_rest/pages/import_page_spec.rb", | ||
| "spec/lib/action_kit_rest/response/collection_spec.rb", | ||
| "spec/lib/action_kit_rest/response/validation_error_spec.rb", | ||
| "spec/lib/action_kit_rest/response/wrapper_spec.rb", | ||
| "spec/lib/action_kit_rest/user_spec.rb", | ||
| "spec/spec_helper.rb", | ||
| "spec/support/shared_contexts/stub_logger.rb" | ||
| ] | ||
| s.homepage = "http://github.com/controlshift/action_kit_rest".freeze | ||
| s.licenses = ["MIT".freeze] | ||
| s.rubygems_version = "3.4.10".freeze | ||
| s.summary = "A wrapper for the ActionKit REST API".freeze | ||
| Gem::Specification.new do |spec| | ||
| spec.name = "action_kit_rest" | ||
| spec.version = ActionKitRest::VERSION::STRING | ||
| spec.authors = ["Nathan Woodhull", "Diego Marcet", "Grey Moore", "Owens Ehimen"] | ||
| spec.email = ["systems@controlshiftlabs.com"] | ||
|
|
||
| s.specification_version = 4 | ||
| spec.summary = "A wrapper for the ActionKit REST API" | ||
| spec.description = "Gem for interacting with the ActionKit API" | ||
| spec.homepage = "https://github.com/controlshift/action_kit_rest" | ||
| spec.license = "MIT" | ||
| spec.required_ruby_version = ">= 3.0.0" | ||
ehimen-io marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| s.add_runtime_dependency(%q<vertebrae>.freeze, [">= 0.6.0"]) | ||
| s.add_development_dependency(%q<bundler>.freeze, [">= 2.0", "< 3.0"]) | ||
| s.add_development_dependency(%q<byebug>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<em-http-request>.freeze, [">= 1.1.5", "< 2.0"]) | ||
| s.add_development_dependency(%q<em-synchrony>.freeze, [">= 1.0.6", "< 2.0"]) | ||
| s.add_development_dependency(%q<eventmachine>.freeze, [">= 1.2.5", "< 2.0"]) | ||
| s.add_development_dependency(%q<juwelier>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<rspec>.freeze, ["~> 3.7"]) | ||
| s.add_development_dependency(%q<rubocop>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<webmock>.freeze, ["~> 3.3"]) | ||
| spec.metadata["homepage_uri"] = spec.homepage | ||
| spec.metadata["source_code_uri"] = spec.homepage | ||
| spec.metadata["changelog_uri"] = "#{spec.homepage}/blob/main/CHANGELOG.md" | ||
| spec.metadata["rubygems_mfa_required"] = "true" | ||
|
|
||
| # Specify which files should be added to the gem when it is released. | ||
| # The `git ls-files -z` loads the files in the RubyGem that have been added into git. | ||
| spec.files = Dir.chdir(__dir__) do | ||
ehimen-io marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| `git ls-files -z`.split("\x0").reject do |f| | ||
| (File.expand_path(f) == __FILE__) || | ||
| f.start_with?(*%w[bin/ spec/ .git .github .document .idea coverage/]) | ||
| end | ||
| end | ||
| spec.require_paths = ["lib"].freeze | ||
|
|
||
| # Runtime dependencies | ||
| spec.add_dependency "vertebrae", "~> 1.0.5" | ||
| spec.add_dependency "hashie", "~> 5.1.0" | ||
| spec.add_dependency "faraday", "~> 2.0" # We use Faraday 2.x APIs directly (Faraday::Middleware, etc.) | ||
| spec.add_dependency "faraday-mashify", "~> 1.0" # Required in lib/action_kit_rest/api.rb | ||
|
|
||
| # Development dependencies | ||
| spec.add_development_dependency "bundler", ">= 2.0", "< 3.0" | ||
| spec.add_development_dependency "byebug" | ||
| spec.add_development_dependency "em-http-request", ">= 1.1.5", "< 2.0" | ||
| spec.add_development_dependency "em-synchrony", ">= 1.0.6", "< 2.0" | ||
| spec.add_development_dependency "eventmachine", ">= 1.2.5", "< 2.0" | ||
| spec.add_development_dependency "rake" | ||
ehimen-io marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| spec.add_development_dependency "rspec", "~> 3.7" | ||
| spec.add_development_dependency "rubocop" | ||
| spec.add_development_dependency "webmock", "~> 3.3" | ||
| end | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.