Conversation
ehimen-io
commented
Feb 17, 2026
ehimen-io
commented
Feb 17, 2026
lavaturtle
reviewed
Feb 18, 2026
Contributor
lavaturtle
left a comment
lavaturtle
left a comment
There was a problem hiding this comment.
Are we dropping support for ruby < 4.0, or are we aiming to support both 3.x and 4.0?
If the former, this should be a major version bump, since it's a breaking change.
If the latter, we should have the Github CI run the tests against all supported ruby versions.
ehimen-io
commented
Feb 19, 2026
Contributor
Author
There was a problem hiding this comment.
To fix a rubocop error
lavaturtle
approved these changes
Feb 20, 2026
.rubocop.yml
Outdated
| Enabled: false | ||
| Style/Documentation: | ||
| Enabled: false | ||
| Enabled: false No newline at end of file |
Contributor
There was a problem hiding this comment.
nitpick: lost a newline here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded Ruby to 4.0.1 and faraday to 2.14, addressing the breaking changes for the upgrades as well.