Skip to content

Upgrade console skeleton to PHP 8.4 #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f3l1x merged 1 commit into from
Feb 12, 2026
Merged

Upgrade console skeleton to PHP 8.4 #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codesniffer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ jobs:
name: "Codesniffer"
uses: contributte/.github/.github/workflows/codesniffer.yml@master
with:
php: "8.2"
php: "8.4"
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ jobs:
name: "Nette Tester"
uses: contributte/.github/.github/workflows/nette-tester-coverage-v2.yml@master
with:
php: "8.2"
php: "8.4"
make: "init coverage"
2 changes: 1 addition & 1 deletion .github/workflows/phpstan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ jobs:
name: "Phpstan"
uses: contributte/.github/.github/workflows/phpstan.yml@master
with:
php: "8.2"
php: "8.4"
make: "init phpstan"
11 changes: 2 additions & 9 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,9 @@ on:
- cron: "0 8 * * 1"

jobs:
test83:
test84:
name: "Nette Tester"
uses: contributte/.github/.github/workflows/nette-tester.yml@master
with:
php: "8.3"
make: "init tests"

test82:
name: "Nette Tester"
uses: contributte/.github/.github/workflows/nette-tester.yml@master
with:
php: "8.2"
php: "8.4"
make: "init tests"
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Main goal is to provide terminal-based console-kit project for Nette developers.

## Installation

You will need `PHP 8.2+` and [Composer](https://getcomposer.org/).
You will need `PHP 8.4+` and [Composer](https://getcomposer.org/).

Create project using composer.

Expand Down
8 changes: 5 additions & 3 deletions app/Bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace App;

use Contributte\Bootstrap\ExtraConfigurator;
use Nette\Bootstrap\Configurator;
use Nette\DI\Compiler;
use Symfony\Component\Console\Application as SymfonyApplication;
use Tracy\Debugger;
Expand All @@ -15,9 +16,10 @@ public static function boot(): ExtraConfigurator
$configurator = new ExtraConfigurator();
$configurator->setTempDirectory(__DIR__ . '/../var/tmp');

$configurator->onCompile[] = function (ExtraConfigurator $configurator, Compiler $compiler): void {
// Add env variables to config structure
$compiler->addConfig(['parameters' => $configurator->getEnvironmentParameters()]);
$configurator->onCompile[] = function (Configurator $configurator, Compiler $compiler): void {
if ($configurator instanceof ExtraConfigurator) {
$compiler->addConfig(['parameters' => $configurator->getEnvironmentParameters()]);
}
};

// According to NETTE_DEBUG env
Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
"license": "MIT",
"type": "project",
"require": {
"php": ">=8.2",
"php": ">=8.4",

"contributte/bootstrap": "^0.6.0",
"contributte/bootstrap": "^0.7.0",
"contributte/di": "^0.6.0",
"contributte/utils": "^0.6.0",
"contributte/utils": "^0.7.0",
"contributte/latte": "^0.7.0",
"contributte/tracy": "^0.7.0",
"contributte/console": "^0.11.0"
Expand Down
Loading