add fiddle as an explicit dependency since it will be removed in Ruby 3.5.0#111
Merged
mperham merged 1 commit intocontribsys:mainfrom Jan 18, 2025
Merged
add fiddle as an explicit dependency since it will be removed in Ruby 3.5.0#111mperham merged 1 commit intocontribsys:mainfrom
mperham merged 1 commit intocontribsys:mainfrom
Conversation
Collaborator
|
Lots of failures |
Contributor
Author
|
@mperham are these CI failures on main already? revert on my fork fails https://github.com/kryali/einhorn/actions/runs/12846878302 |
Collaborator
|
Yeah, they're on main already. I'm looking into it but no ETA. Code rot can be tricky to fix. |
Collaborator
|
Ok, I've got all but one test running successfully. The one test fails on every Ruby, I suspect it's a bad test but I don't know enough about what it's trying to verify. https://github.com/contribsys/einhorn/actions/runs/12847054762 |
Contributor
Author
|
awesome, thank you for fixing!
…On Sat, Jan 18, 2025 at 6:12 PM Mike Perham ***@***.***> wrote:
Merged #111 <#111> into main.
—
Reply to this email directly, view it on GitHub
<#111 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABKWKKY7M5ZTBEFR2WNZK32LLNWPAVCNFSM6AAAAABVN3TLIGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHE4DOMBXHA3TMMQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
any chance this could get released? |
Collaborator
|
It's out now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in ruby 3.4.1 I received a new warning from einhorn announcing the removal of fiddle from the standard library
Feel free to decline this PR if another approach is more appropriate