This repository was archived by the owner on Apr 27, 2022. It is now read-only.
Add support for replacing an existing kv prefix with a new set#49
Open
phroggyy wants to merge 1 commit intocontainous:masterfrom
Open
Add support for replacing an existing kv prefix with a new set#49phroggyy wants to merge 1 commit intocontainous:masterfrom
phroggyy wants to merge 1 commit intocontainous:masterfrom
Conversation
phroggyy
force-pushed
the
feat-config-replace
branch
7 times, most recently
from
af50400 to
b148664
Compare
phroggyy
force-pushed
the
feat-config-replace
branch
from
b148664 to
7be8d41
Compare
Author
|
@ldez any progress on getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
ReplaceConfigthat will remove any keys (for the source's prefix) that are not present in the new config. This is primarily to solve traefik/traefik#2093 – by adding this, we can make Traefik useReplaceConfiginstead.This will have the desired effect of removing any stale keys (that can lead to Traefik picking up config that the user thinks is not present), while maintaining any existing keys.