[release-0.0.99.4] build: Bump github.com/sirupsen/logrus to 1.9.3 #1743
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
... or GHSA-p782-xgp4-8hr8. containers#1245 containers#1743 https://github.com/containers/toolbox/security/dependabot/12 Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 9708cbf)
debarshiray
force-pushed
the
wip/rishi/0.0.99.4.x-CVE-2025-65637
branch
from
5b9386c to
aa63f22
Compare
|
Build failed. ❌ unit-test FAILURE in 1m 44s |
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 27, 2026
Detected by https://www.shellcheck.net/: Line 1255: if ! localtime_target=$(readlink /etc/localtime >/dev/null 2>&3) \ ^-- SC2327 (warning): This command substitution will be empty because the command's output gets redirected away. ^-- SC2328 (error): This redirection takes output away from the command substitution. See: https://www.shellcheck.net/wiki/SC2327 https://www.shellcheck.net/wiki/SC2328 Fallout from 8db414d containers#1701 containers#1739 containers#1743 (cherry picked from commit d32dd5d) (cherry picked from commit a67f614)
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 27, 2026
Until Bats 1.10.0, 'run --keep-empty-lines' had a bug where it counted
the trailing newline on the last line as a separate line [1]. However,
Bats 1.10.0 is only available in Fedora >= 39 and is absent from Fedoras
37 and 38.
[1] Bats commit 6648e2143bffb933
bats-core/bats-core@6648e2143bffb933
bats-core/bats-core#708
containers#1352
containers#1743
(backported from commit f716b23)
debarshiray
pushed a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 27, 2026
Bash 5.3.0 changed the error messages shown by its exec built-in [1].
With Bash 5.2.37:
$ exec /etc
bash: /etc: Is a directory
bash: exec: /etc: cannot execute: Is a directory
With Bash 5.3.0:
$ exec /etc
bash: /etc: Is a directory
The 'assert' function cannot directly handle compound commands. So,
those need to be wrapped in 'bash -c "..."' [2].
[1] Bash commit b8c60bc9ca365f82
See how exec_builtin() handles EX_NOEXEC and EISDIR from
shell_execve() to avoid printing a duplicate error message.
https://cgit.git.savannah.gnu.org/cgit/bash.git/commit/?id=b8c60bc9ca365f82
[2] https://github.com/bats-core/bats-assert
containers#1688
containers#1699
containers#1739
containers#1743
(backported from commit 6c98db6)
(cherry picked from commit 0090893)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh.
The src/go.sum file was updated with
go mod tidy.#1503
https://github.com/containers/toolbox/security/dependabot/26
(cherry picked from commits 3de56c0, efa8da9 and 9708cbf)