Skip to content

Conversation

@olliewalsh
Copy link
Collaborator

@olliewalsh olliewalsh commented Jan 7, 2026

Summary by Sourcery

Adjust RPM test build configuration and relax build-system dependency constraints.

Build:

  • Update Packit COPR and test job targets to use explicit Fedora target instead of a shared anchor.
  • Relax pyproject build-system requirement from a minimum setuptools version to any setuptools version.

Pinning the setuptools version to >=61 breaks rpm builds on centos-stream9
where the setuptools version is older.
The rpm builds are using https://src.fedoraproject.org/rpms/pyproject-rpm-macros
which should work with pyproject.yaml even when the setuptools version does not.

The setuptools/pyproject docs do not mention pinning the setuptools version,
all of the example just show an unversioned dependence on 'setuptools'.

Signed-off-by: Oliver Walsh <owalsh@redhat.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts Packit CI configuration for Fedora RPM tests and relaxes the setuptools build requirement to any available version instead of enforcing >=61.

File-Level Changes

Change Details Files
Simplified Fedora Packit job targets specification for COPR build and tests.
  • Removed the shared fedora_copr_targets anchor from the COPR build job configuration.
  • Inlined the Fedora target list directly under the tests job as a literal list containing fedora-all.
  • Stopped reusing the YAML anchor/alias pattern for Fedora targets, making the configuration more explicit but slightly more repetitive.
.packit.yaml
Relaxed the minimum setuptools version required for building the project.
  • Changed the build-system requirement from setuptools>=61 to setuptools with no explicit minimum version constraint.
  • Left the build backend unchanged as setuptools.build_meta, preserving the existing build mechanism.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @olliewalsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, marked as 'Do Not Merge' (DNM), appears to be a test or work-in-progress related to RPM builds. It refactors the .packit.yaml configuration to explicitly specify fedora-all as a target for test jobs, removing a previously defined YAML anchor. Additionally, it relaxes the minimum version requirement for setuptools in pyproject.toml, potentially to improve build compatibility or address a specific testing scenario.

Highlights

  • Packit Configuration Refinement: The .packit.yaml configuration has been updated to explicitly define fedora-all as a target for test jobs, removing a previously used YAML anchor for target specification.
  • Build System Requirement Adjustment: The pyproject.toml file has been modified to relax the minimum version requirement for setuptools, changing it from setuptools>=61 to simply setuptools.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adjusts the RPM test build configuration by explicitly defining targets in .packit.yaml instead of using a YAML anchor, which improves clarity. It also relaxes the setuptools version requirement in pyproject.toml from a minimum version to any version. While the explicit target definition is a positive change, relaxing the setuptools dependency could potentially introduce build issues if the project relies on features specific to newer setuptools versions.

@olliewalsh
Copy link
Collaborator Author

/packit build --targets epel9

@olliewalsh olliewalsh closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant