-
Notifications
You must be signed in to change notification settings - Fork 293
DNM: rpm build test #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: rpm build test #2285
Conversation
Pinning the setuptools version to >=61 breaks rpm builds on centos-stream9 where the setuptools version is older. The rpm builds are using https://src.fedoraproject.org/rpms/pyproject-rpm-macros which should work with pyproject.yaml even when the setuptools version does not. The setuptools/pyproject docs do not mention pinning the setuptools version, all of the example just show an unversioned dependence on 'setuptools'. Signed-off-by: Oliver Walsh <owalsh@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts Packit CI configuration for Fedora RPM tests and relaxes the setuptools build requirement to any available version instead of enforcing >=61. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @olliewalsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, marked as 'Do Not Merge' (DNM), appears to be a test or work-in-progress related to RPM builds. It refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adjusts the RPM test build configuration by explicitly defining targets in .packit.yaml instead of using a YAML anchor, which improves clarity. It also relaxes the setuptools version requirement in pyproject.toml from a minimum version to any version. While the explicit target definition is a positive change, relaxing the setuptools dependency could potentially introduce build issues if the project relies on features specific to newer setuptools versions.
|
/packit build --targets epel9 |
Summary by Sourcery
Adjust RPM test build configuration and relax build-system dependency constraints.
Build: