Skip to content

Conversation

@olliewalsh
Copy link
Collaborator

@olliewalsh olliewalsh commented Jan 7, 2026

the timeout command suddenly disappeared from the macos github runners this afternoon

Summary by Sourcery

CI:

  • Install coreutils via Homebrew in the macOS GitHub Actions workflow to restore availability of the timeout command.

Signed-off-by: Oliver Walsh <owalsh@redhat.com>
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CI workflow to install GNU coreutils on macOS runners so that the timeout command is available again during CI jobs.

File-Level Changes

Change Details Files
Ensure macOS CI runners have the timeout utility by installing GNU coreutils via Homebrew.
  • Extend Homebrew install line in the macOS CI job to include coreutils alongside existing packages.
  • Rely on coreutils providing the timeout command that disappeared from the default GitHub macOS runners.
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • If this is specifically to restore timeout, consider noting or enforcing the path used in scripts (e.g., gtimeout vs timeout on macOS coreutils) so the CI remains robust even if Homebrew changes the installed binary names.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- If this is specifically to restore `timeout`, consider noting or enforcing the path used in scripts (e.g., `gtimeout` vs `timeout` on macOS coreutils) so the CI remains robust even if Homebrew changes the installed binary names.

## Individual Comments

### Comment 1
<location> `.github/workflows/ci.yml:258` </location>
<code_context>
         shell: bash
         run: |
-           brew install go bats bash jq llama.cpp shellcheck
+           brew install go bats bash jq llama.cpp shellcheck coreutils
            uv run -- make install-requirements

</code_context>

<issue_to_address>
**issue:** Clarify whether GNU coreutils behavior (g-prefixed binaries) is expected in the CI scripts.

On macOS, Homebrew’s `coreutils` installs `g*`-prefixed binaries (e.g., `greadlink`, `gtimeout`) unless `gnubin` is added to `PATH`. Please confirm whether the CI/Makefile scripts assume GNU behavior under the unprefixed names (`readlink`, `timeout`), and if so, either add `coreutils``gnubin` directory to `PATH` or call the `g*` commands explicitly.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@olliewalsh olliewalsh merged commit a5799dd into containers:main Jan 7, 2026
23 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant