-
Notifications
You must be signed in to change notification settings - Fork 293
ci: install coreutils on macos #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Oliver Walsh <owalsh@redhat.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CI workflow to install GNU coreutils on macOS runners so that the timeout command is available again during CI jobs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue, and left some high level feedback:
- If this is specifically to restore
timeout, consider noting or enforcing the path used in scripts (e.g.,gtimeoutvstimeouton macOS coreutils) so the CI remains robust even if Homebrew changes the installed binary names.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If this is specifically to restore `timeout`, consider noting or enforcing the path used in scripts (e.g., `gtimeout` vs `timeout` on macOS coreutils) so the CI remains robust even if Homebrew changes the installed binary names.
## Individual Comments
### Comment 1
<location> `.github/workflows/ci.yml:258` </location>
<code_context>
shell: bash
run: |
- brew install go bats bash jq llama.cpp shellcheck
+ brew install go bats bash jq llama.cpp shellcheck coreutils
uv run -- make install-requirements
</code_context>
<issue_to_address>
**issue:** Clarify whether GNU coreutils behavior (g-prefixed binaries) is expected in the CI scripts.
On macOS, Homebrew’s `coreutils` installs `g*`-prefixed binaries (e.g., `greadlink`, `gtimeout`) unless `gnubin` is added to `PATH`. Please confirm whether the CI/Makefile scripts assume GNU behavior under the unprefixed names (`readlink`, `timeout`), and if so, either add `coreutils`’ `gnubin` directory to `PATH` or call the `g*` commands explicitly.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
the timeout command suddenly disappeared from the macos github runners this afternoon
Summary by Sourcery
CI: