feat: add WASM encrypted layer media type support #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
rodneyosodo
force-pushed
the
feat/wasm-oci-image-support
branch
from
b1a8b99 to
a2f0a9f
Compare
Collaborator
|
It looks like the 3 patches could be squashed into one. Is this the current spec? https://github.com/solo-io/wasm-image-spec |
|
|
||
| isKeyprovider := strings.HasPrefix(scheme, keyProviderSchemePrefix) | ||
| if isKeyprovider { | ||
| keyproviderTried = true |
Collaborator
There was a problem hiding this comment.
What was actually 'tried'?
Collaborator
There was a problem hiding this comment.
Is this supposed to be a fix to existing code? If so, you should send a commit description stating what was fixed. I am not sure from your patch descriptions how this relates to WASM, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for encrypting and decrypting WASM layer media types and improve key provider handling during decryption.
New Features
Tests: