helm,resource-annotator: add chart support for cert-manager. #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
reviewed
Jan 29, 2026
klihub
force-pushed
the
devel/resource-annotator/cert-manager
branch
3 times, most recently
from
3c658bc to
c48c8b1
Compare
Add support for HTTPS certificate generation and injection by cert-manager. Let the stock golang HTTP implementation know about the certificate and key file location, with the hope that it will watch and reload certificates when cert- manager rotates/renews them. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
devel/resource-annotator/cert-manager
branch
from
c48c8b1 to
eca65c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for HTTPS certificate generation and injection by cert-manager. Also, update default key and certificate names to match the ones injected by cert-manager. Finally, let the stock golang HTTP implementation know about the certificate and key file location and take them into use on its own accord, in the hope that it will also watch and reload certificates when cert-manager rotates/renews them.