test: fix macos::eventfd::tests #523
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McNight
requested review from
MatiasVara,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
McNight
force-pushed
the
fix_macos_tests
branch
from
f0b85b6 to
a052c61
Compare
Signed-off-by: McNight <mcnight@mcnight.fr>
McNight
force-pushed
the
fix_macos_tests
branch
from
a052c61 to
e521dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, really like the project so I wanted to participate, despite being still a beginner with Rust.
I tried to run the macOS related tests on my machine but they were not building.
Once it was building, the
test_write_overflowwas not succeeding, and I believe it's because it's using a pipe with no sign of a counter so I deleted the test, but I don't know if we should maybe keep it and rework it?