linux: do not leak errors

[eriksjolund]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical aspect of resource management within the libcrun library by ensuring that error objects are explicitly released when an error condition is met during various mount operations. By adding crun_error_release calls, the changes prevent potential memory leaks and improve the robustness of the error handling mechanisms, particularly in scenarios where mount targets cannot be opened or handler configurations fail.

Highlights

• Error Handling: Introduced crun_error_release(err) calls in src/libcrun/linux.c at various error return points within mount-related functions (process_single_mount, libcrun_set_mounts, libcrun_finalize_mounts). This ensures that error objects are properly deallocated when an error occurs and is propagated, preventing potential memory leaks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly identifies and fixes several memory leaks in error handling paths by releasing the existing error object before creating a new one. While this fixes the leaks, it discards the original error message from the underlying function call, which could be valuable for debugging. A better approach would be to use crun_error_wrap(), which prepends a new contextual message to the existing error, preserving the original details. This would also make the code more concise. I've added suggestions to each of the locations to use crun_error_wrap() instead.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[eriksjolund]

Do you prefer using crun_error_wrap()? I could change that.

[eriksjolund]

I realised I forgot to use crun_error_get_errno(). Anyway crun_error_wrap() seems like a simpler solution. I amended the suggestion by gemini-code-assist.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[giuseppe]

LGTM