container: add missing crun_make_error

[eriksjolund]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling mechanisms within the container management logic by consistently applying the crun_make_error utility. The changes ensure that failures originating from critical system calls like select, fprintf, and read are captured with more explicit and informative error messages, enhancing the overall reliability and debuggability of the container runtime.

Highlights

• Improved Error Handling for select: The libcrun_container_start function now uses crun_make_error to report failures from the select system call, providing more detailed error information including the errno and a descriptive string.
• Robust fprintf Error Reporting: The libcrun_container_spec function has been updated to capture the return value of fprintf and use crun_make_error if an I/O error occurs, ensuring proper error propagation and context.
• Enhanced read Error Reporting: In restore_proxy_process, failures from the read system call are now reported using crun_make_error, offering better diagnostic messages with errno and a specific failure description.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves error handling in libcrun by replacing direct error code returns with calls to crun_make_error. This provides more descriptive error messages and makes the error handling more consistent across the codebase. The changes in libcrun_container_start, libcrun_container_spec, and restore_proxy_process are correct and well-implemented. Additionally, a bug in libcrun_container_spec where it returned a non-zero value on success has been fixed. The changes are clean and improve the overall quality of the code. No issues found.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[eriksjolund]

Update: I added a separate commit for the src/spec.c fix

It's also possible to simplify src/spec.c somewhat

diff --git a/src/spec.c b/src/spec.c
index 3d8c9c9c..9ff11616 100644
--- a/src/spec.c
+++ b/src/spec.c
@@ -127,7 +127,5 @@ crun_command_spec (struct crun_global_arguments *global_args, int argc, char **a
   if (f == NULL)
     return libcrun_make_error (err, errno, "cannot open `%s`", where);
 
-  ret = libcrun_container_spec (! spec_options.rootless, f, err);
-
-  return ret >= 0 ? 0 : ret;
+  return libcrun_container_spec (! spec_options.rootless, f, err);
 }

Should I add that modification as well? in this PR or in a separate PR?

[giuseppe]

LGTM