Skip to content

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 21, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

For podman6

How to verify it

Verify buildah doesn't work with slirp

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Slirp4netns support has been removed.

Rebased on the cgroups v1 removal PR.

@lsm5 lsm5 added the podman 6 breaking changes that should only go into podman 6 label Oct 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lsm5 added 2 commits October 21, 2025 12:00
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Fixes: RUN-3567 (partly)

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5 lsm5 force-pushed the podman6-no-slirp branch from c0c824d to d14aa61 Compare October 21, 2025 16:01
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 added 3 commits October 21, 2025 14:11
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5 lsm5 force-pushed the podman6-no-slirp branch from d14aa61 to 9374d7f Compare October 21, 2025 18:11
@nalind
Copy link
Member

nalind commented Oct 22, 2025

Does this include the changes from #6424?

@lsm5
Copy link
Member Author

lsm5 commented Oct 23, 2025

Does this include the changes from #6424?

I think so. I might need to rebase on main though. Also, one of the crun tests timed out. I retriggered it just now.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TomSweeneyRedHat
Copy link
Member

@lsm needs rebasing

@lsm5
Copy link
Member Author

lsm5 commented Nov 19, 2025

@lsm needs rebasing

@TomSweeneyRedHat lsm is someone else (and he liked the comment 😄) . Might wanna wait for the suggestions when you start @-ing

@TomSweeneyRedHat
Copy link
Member

@lsm5 I can not be held legally responsible for anything that I type before 9:00 in the morning or after 5:00 in the afternoon my time.

@lsm, apologies for the noise!

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/work-in-progress needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. podman 6 breaking changes that should only go into podman 6 stale-pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants