Match and Compare platforms with OSFeatures #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
force-pushed
the
match-features
branch
from
068785e to
60b9ddc
Compare
stevvooe
reviewed
Nov 19, 2024
| { | ||
| "linux(+other)/amd64", | ||
| []string{"windows/amd64", "linux/amd64", "linux/arm64", "linux(+other)/amd64"}, | ||
| []string{"linux(+other)/amd64", "linux/amd64", "windows/amd64", "linux/arm64"}, |
Member
There was a problem hiding this comment.
Do we need a case where the OSVersion prefixes the OSFeatures? ie linux(7.2+other)
Member
Author
There was a problem hiding this comment.
We should define how the OS version can be generically supported as well, possibly similar what is being done with OS Features here
dmcgowan
force-pushed
the
match-features
branch
2 times, most recently
from
cbf253f to
2f65869
Compare
Member
Author
|
I proposed this as a cleaner solution to containerd/containerd#12784. Using the feature in the platform, the manifest selection logic can prefer an erofs manifest based on the availability of the snapshotter. |
Updates the os part of the format to include features after the os version. The guarantees that the format may fully represent the platform structure. Signed-off-by: Derek McGowan <derek@mcg.dev>
Ensure the formatting output is consistent Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
match-features
branch
from
2f65869 to
9f73e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-on to #16
This allows using the OSFeatures field for matching and comparing. To match, the checked platform's features must be a subset of the matcher's platforms. The matcher platform represents the supported features by the host and the checked platforms the platform needed for each image in an index or used to match a plugin instance.
This provides a way to add feature variation in a backwards compatible wherever platform matching is involved.