-
Notifications
You must be signed in to change notification settings - Fork 86
Add integration tests for hook injector plugin #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c68a54 to
eae8638
Compare
|
fell off my radar... can we get a rebase? |
eae8638 to
6da6c17
Compare
|
@mikebrow - I've rebased on Feel free to let me know if there's anything I can improve! |
87ef644 to
366ec3a
Compare
|
Rebased on latest |
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eaa1784 to
a4a1ed6
Compare
|
Rebased on latest, also changed test to use @klihub / @samuelkarp, could you please help review this whenever you have the chance to take a look? |
a4a1ed6 to
ce36b9c
Compare
klihub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ce36b9c to
23d9fdc
Compare
Signed-off-by: Sameer <sameer.saeed@live.ca>
23d9fdc to
67ebccd
Compare
Adds tests for hook injection validation per #86
cc @AbdelrahmanElawady, @mikebrow - feel free to let me know if you have any suggestions!