Skip to content

Conversation

@sameersaeed
Copy link
Contributor

Adds tests for hook injection validation per #86

cc @AbdelrahmanElawady, @mikebrow - feel free to let me know if you have any suggestions!

@sameersaeed sameersaeed force-pushed the hook-injector-tests branch 3 times, most recently from 5c68a54 to eae8638 Compare July 25, 2025 17:59
@sameersaeed sameersaeed marked this pull request as draft October 28, 2025 16:24
@mikebrow
Copy link
Member

mikebrow commented Nov 3, 2025

fell off my radar... can we get a rebase?

@sameersaeed
Copy link
Contributor Author

@mikebrow - I've rebased on main, also made a minor change so that the hook runs on container start rather than on pre-start

Feel free to let me know if there's anything I can improve!

@sameersaeed sameersaeed force-pushed the hook-injector-tests branch 3 times, most recently from 87ef644 to 366ec3a Compare January 13, 2026 03:05
@sameersaeed
Copy link
Contributor Author

Rebased on latest main, can also help look into adding critest tests for this if needed

@sameersaeed sameersaeed marked this pull request as ready for review January 13, 2026 03:12
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sameersaeed sameersaeed force-pushed the hook-injector-tests branch 4 times, most recently from eaa1784 to a4a1ed6 Compare January 27, 2026 03:32
@sameersaeed
Copy link
Contributor Author

Rebased on latest, also changed test to use CreateRuntime hook instead of Prestart, since Prestart is deprecated

@klihub / @samuelkarp, could you please help review this whenever you have the chance to take a look?

@klihub klihub force-pushed the hook-injector-tests branch from a4a1ed6 to ce36b9c Compare January 28, 2026 06:44
Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sameersaeed
Copy link
Contributor Author

Thanks @klihub and @mikebrow, I've rebased on latest

Signed-off-by: Sameer <sameer.saeed@live.ca>
@mikebrow mikebrow merged commit ed596cb into containerd:main Jan 28, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants