Skip to content

Fix Accessibility Violations for Navbar Social Media Links #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangkevin-apr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Accessibility Violations for Navbar Social Media Links #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions themes/containerd/layouts/partials/navbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,19 @@
<div class="navbar-item">
<div class="field is-grouped">
<p class="control">
<a class="button has-background-twitter-blue is-borderless has-text-white" href="{{ $twitterUrl }}">
<a class="button has-background-twitter-blue is-borderless has-text-white" href="{{ $twitterUrl }}" aria-label="Twitter">
<span class="icon">
<i class="fab fa-twitter" aria-hidden="true"></i>
</span>
</a>

<a class="button is-borderless has-background-black has-text-white" href="{{ $githubUrl }}">
<a class="button is-borderless has-background-black has-text-white" href="{{ $githubUrl }}" aria-label="GitHub">
<span class="icon">
<i class="fab fa-github" aria-hidden="true"></i>
</span>
</a>

<a class="button has-background-slack-green is-borderless has-text-white" href="{{ $slackChannel }}">
<a class="button has-background-slack-green is-borderless has-text-white" href="{{ $slackChannel }}" aria-label="Slack">
<span class="icon">
<i class="fab fa-slack" aria-hidden="true"></i>
</span>
Expand Down