fix(plpgsql-deparser): handle = assignment operator in splitAssignment #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(plpgsql-deparser): handle = assignment operator in splitAssignment
Summary
PL/pgSQL allows both
:=and=for variable assignments, butsplitAssignment()only recognized:=. This caused=assignments to fail hydration and becomekind: 'raw'withoutvalueExpr/targetExpr, preventing AST-based transformations (like schema renaming) from working.This fix adds
=as a valid assignment operator while avoiding false positives from:>=,<=,<>,!==>Review & Testing Checklist for Human
=detection edge cases: The logic checks if the previous token is>,<,!, or:to skip comparison operators. Confirm this covers all cases where=should NOT be treated as assignment.assignTokenTextis set but never used - should it be removed or is it needed for future use?Recommended test plan:
pnpm --filter plpgsql-deparser testto verify all tests pass=assignments now get their schema names transformed correctlyNotes