fix(plpgsql-deparser): handle already hydrated expressions in hydrateExpression #263
+66
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where
hydratePlpgsqlAstwould crash withTypeError: query.indexOf is not a functionwhen called on an already-hydrated AST. This occurred becausehydrateExpressionexpectedqueryto always be a string, but when processing an already-hydrated AST, thequeryproperty is aHydratedExprQueryobject.The fix adds a check at the beginning of
hydrateExpressionto detect if the query is already hydrated (using the existingisHydratedExprfunction) and return it unchanged.Use case: This is needed for schema transformation pipelines where the same AST might be processed multiple times, such as in constructive-db's schema name transformer.
Review & Testing Checklist for Human
isHydratedExprfunction correctly identifies all hydrated expression kinds (raw,sql-stmt,sql-expr,assign)query: stringtoquery: string | HydratedExprQuerydoesn't cause TypeScript issues downstreampnpm testinpackages/plpgsql-deparserTest plan: After merging and publishing, update constructive-db to use the new version and verify the schema transformation pipeline works without the
query.indexOferror.Notes