Skip to content

Add fetch timeout to prevent email sending hangs #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anmol1696 merged 5 commits into from
Jan 22, 2026
+7 −1
Merged

Add fetch timeout to prevent email sending hangs #649

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d8ed78
Initial plan
Copilot Jan 22, 2026
a36456d
Add 10-second timeout to fetch operation in fetchLogoAsBase64
Copilot Jan 22, 2026
305bb04
Move clearTimeout to finally block to prevent memory leaks
Copilot Jan 22, 2026
83648b4
Remove trailing whitespace
Copilot Jan 22, 2026
627b30c
Merge branch 'anmol/inline-logo' into copilot/sub-pr-646-again
Anmol1696 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion functions/send-email-link/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,13 @@ const fetchLogoAsBase64 = async (url: string | undefined): Promise<string | unde
logger.warn('Blocked unsafe URL for logo fetch', { url });
return undefined;
}
// Add timeout to prevent hanging on unresponsive servers
const controller = new AbortController();
const timeoutId = setTimeout(() => controller.abort(), 10000); // 10 second timeout

try {
const response = await fetch(url);
const response = await fetch(url, { signal: controller.signal });

if (!response.ok) return url;

const buffer = await response.arrayBuffer();
Expand All @@ -173,6 +177,8 @@ const fetchLogoAsBase64 = async (url: string | undefined): Promise<string | unde
} catch {
logger.warn('Failed to fetch logo for base64 encoding, using original URL', { url });
return url;
} finally {
clearTimeout(timeoutId);
}
};

Expand Down