Add SSRF protection to logo URL fetching #648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fetchLogoAsBase64function fetches user-controlled URLs from the database without validation, allowing potential SSRF attacks against internal services and cloud metadata endpoints.Changes
isUrlSafeToFetchvalidation - Blocks non-HTTP/HTTPS protocols, localhost, private IPv4 ranges (10.x, 172.16-31.x, 192.168.x, 169.254.x, 127.x), and private IPv6 addresses (::1, fe80:, fc00:, fd00:)undefinedfor unsafe URLs, causing emails to render without logos rather than exposing internal resources💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.