Skip to content

Remove choosePort and rely on dynamic, OS-allocated ports during tests#758

Open
Ewen Cheslack-Postava (ewencp) wants to merge 1 commit intoconfluentinc:3.0.xfrom
ewencp:dynamic-ports
Open

Remove choosePort and rely on dynamic, OS-allocated ports during tests#758
Ewen Cheslack-Postava (ewencp) wants to merge 1 commit intoconfluentinc:3.0.xfrom
ewencp:dynamic-ports

Conversation

@ewencp
Copy link
Contributor

No description provided.

@ewencp Ewen Cheslack-Postava (ewencp) requested a review from a team March 12, 2018 03:51
@ewencp
Copy link
Contributor Author

Works in conjunction with confluentinc/rest-utils#90 and avoids Address already in use errors during tests due to choosePort not being a reliable way to select a random available port. Will probably need some work/follow up PRs to make it merge up through all recent branches, especially due to recent addition of Kafka-based coordination.

Copy link
Member

@rayokota Robert Yokota (rayokota) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ewen Cheslack-Postava (@ewencp) , this looks reasonable. Are we still interesting in getting this in?

@cla-assistant
Copy link

cla-assistant bot commented Sep 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants