-
Notifications
You must be signed in to change notification settings - Fork 20
Fixes statement name generation for CP Flink #3242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses statement name generation for Confluent Platform Flink by introducing a new on-premises-specific function that generates names compatible with the 45-character limit enforced by on-prem environments.
Key Changes:
- Added
GenerateStatementNameForOnPrem()function that uses a shorter random identifier (24 hex characters instead of UUID's 36 characters) - Updated on-prem code paths to use the new generator instead of the cloud-compatible
GenerateStatementName()
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/flink/types/statement.go | Introduces new statement name generator optimized for on-prem 45-character limit using 12 random bytes encoded as hex |
| pkg/flink/internal/store/store_onprem.go | Switches from cloud generator to on-prem-specific generator |
| internal/flink/command_statement_create_onprem.go | Switches from cloud generator to on-prem-specific generator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
fhueske
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a Go expert, but the change looks good to me.
Thanks for the fix @vsantwana!




Release Notes
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Creating a statement via CLI without an explicit statement name fails:
Error message:
Current Workaround: explicitly specify a statement name (like stmt-1):
Blast Radius
References
Test & Review
Before represented by command with
confluent(public release). After represented by./confluent(local build created with the PR):