[AI-575] - The tax_lines and discount_lines fields were added

[mar-js]

The tax_lines and discount_lines fields were added to the order field, for both the request and the response.

---

Note

Introduces explicit tax and discount line support across orders and checkout, and consolidates tax schemas.

• Adds tax_lines and discount_lines arrays to order_request, order_update_request, order_response, and checkout order_template
• Creates order_tax_request and order_tax_response (with id, object, parent_id), updating all OpenAPI refs to use them for tax create/update/read
• Replaces deprecated a_order_tax_lines_inner and ordersCreateTaxes_200_response; changes discount_lines in order response from paginated list to a simple array

^{Written by Cursor Bugbot for commit 604f46b. This will update automatically on new commits. Configure here.}

[gemini-code-assist]

Summary of Changes

Hello @mar-js, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the API's capability to handle detailed financial information by integrating 'tax_lines' and 'discount_lines' into both order request and response objects, as well as the checkout schema. These additions allow for a more granular representation and processing of taxes and discounts associated with an order, improving the accuracy and completeness of financial data within the system.

Highlights

• Order Request Schema Update: The 'tax_lines' and 'discount_lines' fields have been added to the order request schema, allowing for the submission of tax and discount details when creating or updating an order.
• Order Response Schema Update: The 'tax_lines' field has been incorporated into the order response schema, providing detailed tax information, including pagination, when retrieving order details.
• Checkout Schema Enhancement: The 'checkout.yml' schema now includes 'tax_lines' and 'discount_lines' fields, enabling the capture of tax and discount information during the checkout process.
• API Schema Definitions: New OpenAPI schema components, 'tax_lines_data_response' and 'order_tax_lines_response', were introduced to formally define the structure of tax line data and its collection within the API specification.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for tax_lines and discount_lines to orders and checkouts by updating the API specification. The changes look good overall, but I've identified a few areas for improvement in the schema definitions to ensure correctness and consistency. Specifically, there's a structural issue with a nested allOf, some missing required fields in the new tax_lines response schema, and a misleading description for discount_lines that isn't enforced by the schema. I've added detailed comments with suggestions to address these points. Since _build/api.yaml appears to be a generated file, please apply the suggested fixes to the source schema files.