Enable cleanup of CUDA RPM leftovers#282
Open
jakirkham wants to merge 1 commit intoconda-forge:mainfrom
Open
Conversation
jakirkham
force-pushed
the
enable_rm_targets
branch
from
41b4827 to
0e50876
Compare
5 tasks
isuruf
reviewed
Oct 1, 2024
Comment on lines
+28
to
+30
| echo 'conda ALL=NOPASSWD: /usr/bin/rm -rf /opt/conda/targets/x86_64-linux' >> /etc/sudoers | ||
| echo 'conda ALL=NOPASSWD: /usr/bin/rm -rf /opt/conda/targets/ppc64le-linux' >> /etc/sudoers | ||
| echo 'conda ALL=NOPASSWD: /usr/bin/rm -rf /opt/conda/targets/sbsa-linux' >> /etc/sudoers |
Member
There was a problem hiding this comment.
You don't need sudo to delete these folders as they are owned by the user.
Member
Author
There was a problem hiding this comment.
Sometimes RPMs contents have weird permissions on them. So wanted to make this robust to that failure mode
Contributor
There was a problem hiding this comment.
This seems like an acceptable answer to me.
hmaarrfk
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
sudofor removing the contents of the CUDA targets. This will make it easier to cleanup after downloading the CUDA RPMs. Plus this will help with managing memory usage in CUDA CI jobs.Needed for PR: conda-forge/conda-forge-ci-setup-feedstock#357