commands.c: fixup cxlmi_cmd_fmapi_get_vcs_info #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the response of command 5200h is variable length, a minimum payload size is required to prevent fixed_length payload error path being entered in sanity_check_mctp_rsp(), in the event that max VCS's/VPPBs is different from the actual number of VCS's/VPPB's returned. We assume that the minimum returned VCS's is 1, and the minimum number of returned VPPB's is also 1. It is unclear from the specification whether it could feasibly be zero returned without returning an error condition. E.g. if the requested VCS ID is incorrect. We assume in this case the response should be "Invalid Input", rather than success with zero returned VCS's. Fixes: 2f14ae0 Signed-off-by: Joshua Lant <joshualant@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the response of command 5200h is variable length, a minimum payload size is required to prevent fixed_length payload error path being entered in sanity_check_mctp_rsp(), in the event that max VCS's/VPPBs is different from the actual number of VCS's/VPPB's returned.
We assume that the minimum returned VCS's is 1, and the minimum number of returned VPPB's is also 1. It is unclear from the specification whether it could feasibly be zero returned without returning an error condition. E.g. if the requested VCS ID is incorrect. We assume in this case the response should be "Invalid Input", rather than success with zero returned VCS's.
Fixes: 2f14ae0